-
Notifications
You must be signed in to change notification settings - Fork 78
Feat/interface impl #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/interface impl #533
Conversation
df8ad81
to
8a46b3a
Compare
Pull Request Test Coverage Report for Build 18244744117Details
💛 - Coveralls |
1cdd123
to
2abe85f
Compare
b5788e1
to
3f709ab
Compare
9e9410b
to
c0dcacd
Compare
@Norbytus I will have a more detailed look at this this weekend and might do some tinkering myself. Is this up to date? Might push some changes directly to this branch. |
You can to this branch, it's ok. |
Hi, this looks like there was a lot of work done, great job! Any chance this would be completed and merged? I'm thinking about using ext-php-rs for my extension and this would simplify the implementation a lot. |
@jakubkulhan had to take some time off, but will push this now that I have more time. There is some work left, but should be done soon. |
@Norbytus could you rebase onto master? I can't do this because workflow files changed and those need extra permissions to update. |
432b52b
to
c0a7827
Compare
Done |
@Norbytus will try to do some refactoring on the derives and have some minor code style adjustments in the works. Ill also add some more tests. Other than that it looks good to me. Thank you so much for your work and sorry again for the huge delay getting to this. |
No problem, i will check tomorrow |
Description
❤️ Thank you for your contribution!